linux-kernel - Re: [PATCH 2/3] iio: dac: ad5686: add of_match

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sun, 22 Mar 2020 02:33:37 +0200
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Michael Auchter <michael.auchter@...com>
Cc:     Lars-Peter Clausen <lars@...afoo.de>,
        Michael Hennerich <Michael.Hennerich@...log.com>,
        Stefan Popa <stefan.popa@...log.com>,
        Jonathan Cameron <jic23@...nel.org>,
        Hartmut Knaack <knaack.h@....de>,
        Peter Meerwald-Stadler <pmeerw@...erw.net>,
        Linux PM <linux-pm@...r.kernel.org>,
        linux-iio <linux-iio@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/3] iio: dac: ad5686: add of_match_table

On Wed, Mar 18, 2020 at 5:56 PM Michael Auchter <michael.auchter@...com> wrote:
>
> Add of_match_table to this driver, so devices can be probed based on
> device tree contents.

> +               .of_match_table = of_match_ptr(ad5686_of_match),

There is no need to use of_match_ptr().
Didn't you get a compiler warning for !OF case?

-- 
With Best Regards,
Andy Shevchenko