linux-kernel - Re: [PATCH 01/13] iio: accel: kxsd9: Use suitable format specifier

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 22 Mar 2020 08:36:18 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Nishant Malpani <nish.malpani25@...il.com>
Cc:     kbuild-all@...ts.01.org, jic23@...nel.org,
        andriy.shevchenko@...ux.intel.com, joe@...ches.com,
        knaack.h@....de, lars@...afoo.de, pmeerw@...erw.net,
        nish.malpani25@...il.com, linux-iio@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 01/13] iio: accel: kxsd9: Use suitable format specifier

Hi Nishant,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on v5.6-rc6]
[also build test ERROR on next-20200320]
[cannot apply to iio/togreg]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Nishant-Malpani/iio-Use-suitable-format-specifiers/20200322-050532
base:    fb33c6510d5595144d585aa194d377cf74d31911
config: x86_64-randconfig-s0-20200322 (attached as .config)
compiler: gcc-4.9 (Debian 4.9.2-10+deb8u1) 4.9.2
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   drivers/iio/accel/kxsd9-i2c.c: In function 'kxsd9_i2c_probe':
   drivers/iio/accel/kxsd9-i2c.c:68:0: error: unterminated argument list invoking macro "dev_err"
    MODULE_DESCRIPTION("KXSD9 accelerometer I2C interface");
    ^
>> drivers/iio/accel/kxsd9-i2c.c:24:3: error: 'dev_err' undeclared (first use in this function)
      dev_err(&i2c->dev, "Failed to register i2c regmap %pe\n",
      ^
   drivers/iio/accel/kxsd9-i2c.c:24:3: note: each undeclared identifier is reported only once for each function it appears in
   drivers/iio/accel/kxsd9-i2c.c:24:3: error: expected ';' at end of input
   drivers/iio/accel/kxsd9-i2c.c:24:3: error: expected declaration or statement at end of input
   drivers/iio/accel/kxsd9-i2c.c:24:3: error: expected declaration or statement at end of input
   drivers/iio/accel/kxsd9-i2c.c:24:3: warning: no return statement in function returning non-void [-Wreturn-type]
   drivers/iio/accel/kxsd9-i2c.c: At top level:
   drivers/iio/accel/kxsd9-i2c.c:12:12: warning: 'kxsd9_i2c_probe' defined but not used [-Wunused-function]
    static int kxsd9_i2c_probe(struct i2c_client *i2c,
               ^

vim +/dev_err +24 drivers/iio/accel/kxsd9-i2c.c

    11	
    12	static int kxsd9_i2c_probe(struct i2c_client *i2c,
    13				   const struct i2c_device_id *id)
    14	{
    15		static const struct regmap_config config = {
    16			.reg_bits = 8,
    17			.val_bits = 8,
    18			.max_register = 0x0e,
    19		};
    20		struct regmap *regmap;
    21	
    22		regmap = devm_regmap_init_i2c(i2c, &config);
    23		if (IS_ERR(regmap)) {
  > 24			dev_err(&i2c->dev, "Failed to register i2c regmap %pe\n",
    25				regmap;
    26			return PTR_ERR(regmap);
    27		}
    28	
    29		return kxsd9_common_probe(&i2c->dev,
    30					  regmap,
    31					  i2c->name);
    32	}
    33	
    34	static int kxsd9_i2c_remove(struct i2c_client *client)
    35	{
    36		return kxsd9_common_remove(&client->dev);
    37	}
    38	
    39	#ifdef CONFIG_OF
    40	static const struct of_device_id kxsd9_of_match[] = {
    41		{ .compatible = "kionix,kxsd9", },
    42		{ },
    43	};
    44	MODULE_DEVICE_TABLE(of, kxsd9_of_match);
    45	#else
    46	#define kxsd9_of_match NULL
    47	#endif
    48	
    49	static const struct i2c_device_id kxsd9_i2c_id[] = {
    50		{"kxsd9", 0},
    51		{ },
    52	};
    53	MODULE_DEVICE_TABLE(i2c, kxsd9_i2c_id);
    54	
    55	static struct i2c_driver kxsd9_i2c_driver = {
    56		.driver = {
    57			.name	= "kxsd9",
    58			.of_match_table = of_match_ptr(kxsd9_of_match),
    59			.pm = &kxsd9_dev_pm_ops,
    60		},
    61		.probe		= kxsd9_i2c_probe,
    62		.remove		= kxsd9_i2c_remove,
    63		.id_table	= kxsd9_i2c_id,
    64	};
    65	module_i2c_driver(kxsd9_i2c_driver);
    66	
    67	MODULE_LICENSE("GPL v2");
  > 68	MODULE_DESCRIPTION("KXSD9 accelerometer I2C interface");

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (29460 bytes)