linux-kernel - Re: [PATCH] clocksource/drivers/timer-vf-pit: Fix build error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8e5a2afc-4b5d-9e37-d529-42773d5af007@linaro.org>
Date:   Mon, 23 Mar 2020 11:02:05 +0100
From:   Daniel Lezcano <daniel.lezcano@...aro.org>
To:     afzal mohammed <afzal.mohd.ma@...il.com>
Cc:     kbuild test robot <lkp@...el.com>, kbuild-all@...ts.01.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] clocksource/drivers/timer-vf-pit: Fix build error

On 23/03/2020 07:11, afzal mohammed wrote:
> Recently all usages of setup_irq() was replaced by request_irq(). The
> replacement in timer-vf-pit.c missed closing parentheses resulting in
> build error (vf610m4_defconfig). Fix it.
> 
> Fixes: cc2550b421aa ("clocksource: Replace setup_irq() by request_irq()")
> Reported-by: kbuild test robot <lkp@...el.com>
> Signed-off-by: afzal mohammed <afzal.mohd.ma@...il.com>
> ---
>  drivers/clocksource/timer-vf-pit.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/clocksource/timer-vf-pit.c b/drivers/clocksource/timer-vf-pit.c
> index 7ad4a8b008c2..1a86a4e7e344 100644
> --- a/drivers/clocksource/timer-vf-pit.c
> +++ b/drivers/clocksource/timer-vf-pit.c
> @@ -129,7 +129,7 @@ static int __init pit_clockevent_init(unsigned long rate, int irq)
>  	__raw_writel(PITTFLG_TIF, clkevt_base + PITTFLG);
>  
>  	BUG_ON(request_irq(irq, pit_timer_interrupt, IRQF_TIMER | IRQF_IRQPOLL,
> -			   "VF pit timer", &clockevent_pit);
> +			   "VF pit timer", &clockevent_pit));

Applied


-- 
 <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog