linux-kernel - Re: [PATCH] clocksource/drivers/timer-vf-pit: Fix build error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 31 Mar 2020 13:40:36 +0200
From:   Daniel Lezcano <daniel.lezcano@...aro.org>
To:     Thomas Gleixner <tglx@...utronix.de>
Cc:     afzal mohammed <afzal.mohd.ma@...il.com>,
        kbuild test robot <lkp@...el.com>, kbuild-all@...ts.01.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] clocksource/drivers/timer-vf-pit: Fix build error


Hi Thomas,

I was about to send a PR with the revert and this patch. As you picked
up the revert, do you mind to pick also this one?

Thanks

  -- Daniel


On 23/03/2020 07:11, afzal mohammed wrote:
> Recently all usages of setup_irq() was replaced by request_irq().
> The replacement in timer-vf-pit.c missed closing parentheses
> resulting in build error (vf610m4_defconfig). Fix it.
>
> Fixes: cc2550b421aa ("clocksource: Replace setup_irq() by
> request_irq()") Reported-by: kbuild test robot <lkp@...el.com>
> Signed-off-by: afzal mohammed <afzal.mohd.ma@...il.com> ---
> drivers/clocksource/timer-vf-pit.c | 2 +- 1 file changed, 1
> insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clocksource/timer-vf-pit.c
> b/drivers/clocksource/timer-vf-pit.c index
> 7ad4a8b008c2..1a86a4e7e344 100644 ---
> a/drivers/clocksource/timer-vf-pit.c +++
> b/drivers/clocksource/timer-vf-pit.c @@ -129,7 +129,7 @@ static int
> __init pit_clockevent_init(unsigned long rate, int irq)
> __raw_writel(PITTFLG_TIF, clkevt_base + PITTFLG);
>
> BUG_ON(request_irq(irq, pit_timer_interrupt, IRQF_TIMER |
> IRQF_IRQPOLL, -			   "VF pit timer", &clockevent_pit); +			   "VF
> pit timer", &clockevent_pit));
>
> clockevent_pit.cpumask = cpumask_of(0); clockevent_pit.irq = irq;
>


-- 
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog