linux-kernel - Re: [PATCH v7 1/5] usb: hci: add hc_driver as argument for usb_hcd_pci

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200323161151.GT72691@vkoul-mobl>
Date:   Mon, 23 Mar 2020 21:41:51 +0530
From:   Vinod Koul <vkoul@...nel.org>
To:     Alan Stern <stern@...land.harvard.edu>
Cc:     kbuild test robot <lkp@...el.com>, kbuild-all@...ts.01.org,
        clang-built-linux@...glegroups.com,
        Mathias Nyman <mathias.nyman@...el.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "linux-arm-msm@...r.kernel.org, Bjorn Andersson" 
        <bjorn.andersson@...aro.org>,
        Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>,
        Christian Lamparter <chunkeey@...glemail.com>,
        John Stultz <john.stultz@...aro.org>,
        Andreas Böhler <dev@...ehler.at>,
        linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
        Mathias Nyman <mathias.nyman@...ux.intel.com>
Subject: Re: [PATCH v7 1/5] usb: hci: add hc_driver as argument for
 usb_hcd_pci_probe

On 23-03-20, 11:48, Alan Stern wrote:
> On Mon, 23 Mar 2020, Vinod Koul wrote:
> 
> > On 23-03-20, 22:49, kbuild test robot wrote:
> > > Hi Vinod,
> > > 
> > > I love your patch! Yet something to improve:
> > 
> > Thanks for the report.
> > 
> > > [auto build test ERROR on v5.6-rc7]
> > > [also build test ERROR on next-20200323]
> > > [cannot apply to usb/usb-testing]
> > > [if your patch is applied to the wrong git tree, please drop us a note to help
> > > improve the system. BTW, we also suggest to use '--base' option to specify the
> > > base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
> > > 
> > > url:    https://github.com/0day-ci/linux/commits/Vinod-Koul/usb-xhci-Add-support-for-Renesas-USB-controllers/20200323-203447
> > > base:    16fbf79b0f83bc752cee8589279f1ebfe57b3b6e
> > > config: x86_64-defconfig (attached as .config)
> > > compiler: clang version 11.0.0 (https://github.com/llvm/llvm-project 006244152d6c7dd6a390ff89b236cc7801834b46)
> > > reproduce:
> > >         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> > >         chmod +x ~/bin/make.cross
> > >         # save the attached .config to linux build tree
> > >         COMPILER=clang make.cross ARCH=x86_64 
> > > 
> > > If you fix the issue, kindly add following tag
> > > Reported-by: kbuild test robot <lkp@...el.com>
> > > 
> > > All errors (new ones prefixed by >>):
> > > 
> > >    In file included from drivers/usb/host/uhci-hcd.c:847:
> > > >> drivers/usb/host/uhci-pci.c:297:36: error: passing 'const struct hc_driver *' to parameter of type 'struct hc_driver *' discards qualifiers [-Werror,-Wincompatible-pointer-types-discards-qualifiers]
> > >            return usb_hcd_pci_probe(dev, id, &uhci_driver);
> > >                                              ^~~~~~~~~~~~
> > >    include/linux/usb/hcd.h:483:27: note: passing argument to parameter 'driver' here
> > >                                 struct hc_driver *driver);
> > 
> > I need to drop the const qualifiers for uhci_driver, I have checked that
> > and will send v8 with this fix
> 
> No, don't remove the qualifier for uhci_driver.  Instead, change 
> usb_hcd_pci_probe(): make driver a pointer to const.

Thanks that is indeed a better idea.

Will send v8 shortly

-- 
~Vinod