linux-kernel - Re: [PATCH v7 1/5] usb: hci: add hc_driver as argument for usb_hcd_pci

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 24 Mar 2020 03:30:10 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Vinod Koul <vkoul@...nel.org>
Cc:     kbuild-all@...ts.01.org, Mathias Nyman <mathias.nyman@...el.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "linux-arm-msm@...r.kernel.org, Bjorn Andersson" 
        <bjorn.andersson@...aro.org>, Vinod Koul <vkoul@...nel.org>,
        Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>,
        Christian Lamparter <chunkeey@...glemail.com>,
        John Stultz <john.stultz@...aro.org>,
        Alan Stern <stern@...land.harvard.edu>,
        Andreas Böhler <dev@...ehler.at>,
        linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
        Mathias Nyman <mathias.nyman@...ux.intel.com>
Subject: Re: [PATCH v7 1/5] usb: hci: add hc_driver as argument for
 usb_hcd_pci_probe

Hi Vinod,

I love your patch! Perhaps something to improve:

[auto build test WARNING on v5.6-rc7]
[also build test WARNING on next-20200323]
[cannot apply to usb/usb-testing]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Vinod-Koul/usb-xhci-Add-support-for-Renesas-USB-controllers/20200323-203447
base:    16fbf79b0f83bc752cee8589279f1ebfe57b3b6e
config: i386-allyesconfig (attached as .config)
compiler: gcc-7 (Debian 7.5.0-5) 7.5.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

   In file included from drivers/usb/host/uhci-hcd.c:847:0:
   drivers/usb/host/uhci-pci.c: In function 'uhci_pci_probe':
>> drivers/usb/host/uhci-pci.c:297:36: warning: passing argument 3 of 'usb_hcd_pci_probe' discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
     return usb_hcd_pci_probe(dev, id, &uhci_driver);
                                       ^
   In file included from drivers/usb/host/uhci-hcd.c:42:0:
   include/linux/usb/hcd.h:481:12: note: expected 'struct hc_driver *' but argument is of type 'const struct hc_driver *'
    extern int usb_hcd_pci_probe(struct pci_dev *dev,
               ^~~~~~~~~~~~~~~~~

vim +297 drivers/usb/host/uhci-pci.c

   294	
   295	static int uhci_pci_probe(struct pci_dev *dev, const struct pci_device_id *id)
   296	{
 > 297		return usb_hcd_pci_probe(dev, id, &uhci_driver);
   298	}
   299	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (71371 bytes)