linux-kernel - RE: [RESEND PATCH] acpi: Add NHLT table signature

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 23 Mar 2020 16:36:31 +0000
From:   "Kaneda, Erik" <erik.kaneda@...el.com>
To:     "Rafael J. Wysocki" <rjw@...ysocki.net>,
        "Rojewski, Cezary" <cezary.rojewski@...el.com>
CC:     "linux-acpi@...r.kernel.org" <linux-acpi@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "lenb@...nel.org" <lenb@...nel.org>,
        "rafael@...nel.org" <rafael@...nel.org>,
        "Moore, Robert" <robert.moore@...el.com>,
        "Wysocki, Rafael J" <rafael.j.wysocki@...el.com>
Subject: RE: [RESEND PATCH] acpi: Add NHLT table signature



> -----Original Message-----
> From: linux-acpi-owner@...r.kernel.org <linux-acpi-
> owner@...r.kernel.org> On Behalf Of Rafael J. Wysocki
> Sent: Saturday, March 21, 2020 3:36 AM
> To: Rojewski, Cezary <cezary.rojewski@...el.com>
> Cc: linux-acpi@...r.kernel.org; linux-kernel@...r.kernel.org; Kaneda, Erik
> <erik.kaneda@...el.com>; lenb@...nel.org; rafael@...nel.org; Kaneda, Erik
> <erik.kaneda@...el.com>; Moore, Robert <robert.moore@...el.com>;
> Wysocki, Rafael J <rafael.j.wysocki@...el.com>
> Subject: Re: [RESEND PATCH] acpi: Add NHLT table signature
> 
> On Friday, March 20, 2020 8:27:27 PM CET Cezary Rojewski wrote:
> > NHLT (Non-HDAudio Link Table) provides configuration of audio
> > endpoints for Intel SST (Smart Sound Technology) DSP products.
> > Similarly to other ACPI tables, data provided by BIOS may not describe
> > it correctly, thus overriding is required.
> >
> > ACPI override mechanism checks for unknown signature before
> proceeding.
> > Update known signatures array to support NHLT.
> >
> > Cc: Erik Kaneda <erik.kaneda@...el.com>
> > Cc: Robert Moore <robert.moore@...el.com>
> > Cc: Rafael J. Wysocki <rafael.j.wysocki@...el.com>
> > Signed-off-by: Cezary Rojewski <cezary.rojewski@...el.com>
> > ---
> >  drivers/acpi/tables.c | 2 +-
> >  include/acpi/actbl2.h | 1 +
> >  2 files changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/acpi/tables.c b/drivers/acpi/tables.c index
> > 180ac4329763..0e905c3d1645 100644
> > --- a/drivers/acpi/tables.c
> > +++ b/drivers/acpi/tables.c
> > @@ -501,7 +501,7 @@ static const char * const table_sigs[] = {
> >  	ACPI_SIG_WDDT, ACPI_SIG_WDRT, ACPI_SIG_DSDT,
> ACPI_SIG_FADT,
> >  	ACPI_SIG_PSDT, ACPI_SIG_RSDT, ACPI_SIG_XSDT, ACPI_SIG_SSDT,
> >  	ACPI_SIG_IORT, ACPI_SIG_NFIT, ACPI_SIG_HMAT, ACPI_SIG_PPTT,
> > -	NULL };
> > +	ACPI_SIG_NHLT, NULL };
> >
> >  #define ACPI_HEADER_SIZE sizeof(struct acpi_table_header)
> >
> > diff --git a/include/acpi/actbl2.h b/include/acpi/actbl2.h index
> > e45ced27f4c3..876ccf50ec36 100644
> > --- a/include/acpi/actbl2.h
> > +++ b/include/acpi/actbl2.h
> > @@ -43,6 +43,7 @@
> >  #define ACPI_SIG_SBST           "SBST"	/* Smart Battery Specification Table
> */
> >  #define ACPI_SIG_SDEI           "SDEI"	/* Software Delegated Exception
> Interface Table */
> >  #define ACPI_SIG_SDEV           "SDEV"	/* Secure Devices table */
> > +#define ACPI_SIG_NHLT           "NHLT"	/* Non-HDAudio Link Table */
> >
> >  /*
> >   * All tables must be byte-packed to match the ACPI specification,
> > since
> >
> 
> This should go in through the ACPICA upstream IMO.
> 
I'll add this to ACPICA for now and we'll work on implementing table compiler support for ACPICA in the near future.

Erik
> 
>