linux-kernel - Re: [PATCH] mlxsw: spectrum_cnt: Fix 64-bit division in mlxsw_sp_counter_resources

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 23 Mar 2020 20:57:44 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     natechancellor@...il.com
Cc:     jiri@...lanox.com, idosch@...lanox.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mlxsw: spectrum_cnt: Fix 64-bit division in
 mlxsw_sp_counter_resources_register

From: Nathan Chancellor <natechancellor@...il.com>
Date: Thu, 19 Mar 2020 19:16:38 -0700

> When building arm32 allyesconfig:
> 
> ld.lld: error: undefined symbol: __aeabi_uldivmod
>>>> referenced by spectrum_cnt.c
>>>>               net/ethernet/mellanox/mlxsw/spectrum_cnt.o:(mlxsw_sp_counter_resources_register) in archive drivers/built-in.a
>>>> did you mean: __aeabi_uidivmod
>>>> defined in: arch/arm/lib/lib.a(lib1funcs.o)
> 
> pool_size and bank_size are u64; use div64_u64 so that 32-bit platforms
> do not error.
> 
> Fixes: ab8c4cc60420 ("mlxsw: spectrum_cnt: Move config validation along with resource register")
> Signed-off-by: Nathan Chancellor <natechancellor@...il.com>

Applied to net-next.

Please be clear about the intended target GIT tree for your changes in the
Subject line in the future, thank you.