linux-kernel - Re: [PATCH v2] ipv4: fix a RCU-list lock in inet_dump

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200323.210026.2188935498095960390.davem@davemloft.net>
Date:   Mon, 23 Mar 2020 21:00:26 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     cai@....pw
Cc:     alexander.h.duyck@...ux.intel.com, kuznet@....inr.ac.ru,
        kuba@...nel.org, yoshfuji@...ux-ipv6.org, dsahern@...il.com,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] ipv4: fix a RCU-list lock in inet_dump_fib()

From: Qian Cai <cai@....pw>
Date: Thu, 19 Mar 2020 22:54:21 -0400

> There is a place,
> 
> inet_dump_fib()
>   fib_table_dump
>     fn_trie_dump_leaf()
>       hlist_for_each_entry_rcu()
> 
> without rcu_read_lock() will trigger a warning,
> 
>  WARNING: suspicious RCU usage
 ...
> Fixes: 18a8021a7be3 ("net/ipv4: Plumb support for filtering route dumps")
> Signed-off-by: Qian Cai <cai@....pw>

Applied and queued up for -stable, thank you.