[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20200324095153.GF1922688@smile.fi.intel.com>
Date: Tue, 24 Mar 2020 11:51:53 +0200
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Matti Vaittinen <matti.vaittinen@...rohmeurope.com>
Cc: mazziesaccount@...il.com,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Linus Walleij <linus.walleij@...aro.org>,
Mikko Mutanen <mikko.mutanen@...rohmeurope.com>,
Markus Laine <markus.laine@...rohmeurope.com>,
Andrew Morton <akpm@...ux-foundation.org>,
Ard Biesheuvel <ardb@...nel.org>, Borislav Petkov <bp@...e.de>,
Brendan Higgins <brendanhiggins@...gle.com>,
Changbin Du <changbin.du@...el.com>,
Dan Williams <dan.j.williams@...el.com>,
David Gow <davidgow@...gle.com>,
"David S. Miller" <davem@...emloft.net>,
devicetree@...r.kernel.org, Gary Hook <Gary.Hook@....com>,
Herbert Xu <herbert@...dor.apana.org.au>,
Krzysztof Kozlowski <krzk@...nel.org>,
linux-kernel@...r.kernel.org, linux-pm@...r.kernel.org,
Mark Rutland <mark.rutland@....com>,
Masahiro Yamada <yamada.masahiro@...ionext.com>,
Masami Hiramatsu <mhiramat@...nel.org>,
Mikhail Zaslonko <zaslonko@...ux.ibm.com>,
Randy Dunlap <rdunlap@...radead.org>,
Rob Herring <robh+dt@...nel.org>,
Sebastian Reichel <sre@...nel.org>,
Shuah Khan <skhan@...uxfoundation.org>,
Tal Gilboa <talgi@...lanox.com>,
Thomas Gleixner <tglx@...utronix.de>,
Uwe Kleine-König <uwe@...ine-koenig.org>,
Vincenzo Frascino <vincenzo.frascino@....com>,
Vladimir Oltean <olteanv@...il.com>,
Mark Brown <broonie@...nel.org>,
Liam Girdwood <lgirdwood@...il.com>
Subject: Re: [PATCH v6 09/10] power: supply: Support ROHM bd99954 charger
On Tue, Mar 24, 2020 at 11:50:24AM +0200, Andy Shevchenko wrote:
> On Tue, Mar 24, 2020 at 10:32:19AM +0200, Matti Vaittinen wrote:
> > +static int bd9995x_get_prop_batt_present(struct bd9995x_device *bd)
> > +{
> > + int ret, tmp;
> > +
> > + ret = regmap_field_read(bd->rmap_fields[F_BATTEMP], &tmp);
> > + if (ret)
> > + return false;
> > +
>
> > + return (tmp != BATT_OPEN) ? true : false;
>
> C 101 (I saw somewhere coccinelle script for this):
>
> return tmp != BATT_OPEN;
>
> > +}
Ah, and even more. Mistype of function and return value.
--
With Best Regards,
Andy Shevchenko
Powered by blists - more mailing lists