linux-kernel - Re: [PATCH v6 09/10] power: supply: Support ROHM bd99954 charger

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200324103557.GH1922688@smile.fi.intel.com>
Date:   Tue, 24 Mar 2020 12:35:57 +0200
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Matti Vaittinen <matti.vaittinen@...rohmeurope.com>
Cc:     mazziesaccount@...il.com,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Linus Walleij <linus.walleij@...aro.org>,
        Mikko Mutanen <mikko.mutanen@...rohmeurope.com>,
        Markus Laine <markus.laine@...rohmeurope.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Ard Biesheuvel <ardb@...nel.org>, Borislav Petkov <bp@...e.de>,
        Brendan Higgins <brendanhiggins@...gle.com>,
        Changbin Du <changbin.du@...el.com>,
        Dan Williams <dan.j.williams@...el.com>,
        David Gow <davidgow@...gle.com>,
        "David S. Miller" <davem@...emloft.net>,
        devicetree@...r.kernel.org, Gary Hook <Gary.Hook@....com>,
        Herbert Xu <herbert@...dor.apana.org.au>,
        Krzysztof Kozlowski <krzk@...nel.org>,
        linux-kernel@...r.kernel.org, linux-pm@...r.kernel.org,
        Mark Rutland <mark.rutland@....com>,
        Masahiro Yamada <yamada.masahiro@...ionext.com>,
        Masami Hiramatsu <mhiramat@...nel.org>,
        Mikhail Zaslonko <zaslonko@...ux.ibm.com>,
        Randy Dunlap <rdunlap@...radead.org>,
        Rob Herring <robh+dt@...nel.org>,
        Sebastian Reichel <sre@...nel.org>,
        Shuah Khan <skhan@...uxfoundation.org>,
        Tal Gilboa <talgi@...lanox.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Uwe Kleine-König <uwe@...ine-koenig.org>,
        Vincenzo Frascino <vincenzo.frascino@....com>,
        Vladimir Oltean <olteanv@...il.com>,
        Mark Brown <broonie@...nel.org>,
        Liam Girdwood <lgirdwood@...il.com>
Subject: Re: [PATCH v6 09/10] power: supply: Support ROHM bd99954 charger

On Tue, Mar 24, 2020 at 11:50:24AM +0200, Andy Shevchenko wrote:
> On Tue, Mar 24, 2020 at 10:32:19AM +0200, Matti Vaittinen wrote:

> > +#include <linux/acpi.h>
> 
> > +#include <linux/of.h>
> 
> I didn't find any evidence of use of those two, otherwise, missed property.h
> and perhaps mod_devicetable.h.

...

> > +MODULE_DEVICE_TABLE(of, bd9995x_of_match);

> > +MODULE_DEVICE_TABLE(acpi, bd9995x_acpi_match);

I have to add since you are using those macros without ifdeffery, you should
get warning in !ACPI and/or !OF cases.

So, drop those of_match_ptr() / ACPI_PTR() and thus above headers.

-- 
With Best Regards,
Andy Shevchenko