linux-kernel - RE: [PATCH v2 1/1] scsi: ufs: Enable block layer runtime PM for well-known logical units

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <SN6PR04MB464074937DF99880D9EF7709FCCE0@SN6PR04MB4640.namprd04.prod.outlook.com>
Date:   Wed, 25 Mar 2020 13:11:46 +0000
From:   Avri Altman <Avri.Altman@....com>
To:     Can Guo <cang@...eaurora.org>,
        "asutoshd@...eaurora.org" <asutoshd@...eaurora.org>,
        "nguyenb@...eaurora.org" <nguyenb@...eaurora.org>,
        "hongwus@...eaurora.org" <hongwus@...eaurora.org>,
        "rnayak@...eaurora.org" <rnayak@...eaurora.org>,
        "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
        "kernel-team@...roid.com" <kernel-team@...roid.com>,
        "saravanak@...gle.com" <saravanak@...gle.com>,
        "salyzyn@...gle.com" <salyzyn@...gle.com>
CC:     Alim Akhtar <alim.akhtar@...sung.com>,
        "James E.J. Bottomley" <jejb@...ux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@...cle.com>,
        Stanley Chu <stanley.chu@...iatek.com>,
        Bean Huo <beanhuo@...ron.com>,
        Bart Van Assche <bvanassche@....org>,
        Venkat Gopalakrishnan <venkatg@...eaurora.org>,
        Tomas Winkler <tomas.winkler@...el.com>,
        open list <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v2 1/1] scsi: ufs: Enable block layer runtime PM for
 well-known logical units

> 
> For the genernal UFS SCSI devices, block layer RPM is enabled for them
> when they are probed by their driver. However block layer RPM is not
> enabled for UFS well-known SCSI devices.
> 
> As UFS SCSI devices have their corresponding BSG char devices, accessing
> these BSG char devices may result in sending requests to the SCSI devices
> through their request queues. If BSG IOCTL sends a request to a well-known
> SCSI device when hba is not runtime active, as block layer RPM is not
> eanbled for the well-known SCSI device, hba, which is at the top of its
> parent chain, shall not be resumed, then unexpected error would happen.
While at it, can you fix the ufs-bsg as well?
Add this call to ufs_bsg_probe() and revert commit 74e5e468b664
(scsi: ufs-bsg: Wake the device before sending raw upiu commands) ?

Thanks,
Avri