linux-kernel - Re: [PATCH] clk: Pass correct arguments to __clk_hw_register

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <158510329289.125146.2737057581185153152@swboyd.mtv.corp.google.com>
Date:   Tue, 24 Mar 2020 19:28:12 -0700
From:   Stephen Boyd <sboyd@...nel.org>
To:     Michael Turquette <mturquette@...libre.com>,
        Stephen Boyd <sboyd@...nel.org>
Cc:     linux-kernel@...r.kernel.org, linux-clk@...r.kernel.org,
        Maxime Ripard <maxime@...no.tech>
Subject: Re: [PATCH] clk: Pass correct arguments to __clk_hw_register_gate()

Quoting Stephen Boyd (2020-03-24 19:22:57)
> diff --git a/include/linux/clk-provider.h b/include/linux/clk-provider.h
> index 952ac035bab9..95cc8a4f6e39 100644
> --- a/include/linux/clk-provider.h
> +++ b/include/linux/clk-provider.h
> @@ -539,10 +539,10 @@ struct clk *clk_register_gate(struct device *dev, const char *name,
>   * @clk_gate_flags: gate-specific flags for this clock
>   * @lock: shared register lock for this clock
>   */
> -#define clk_hw_register_gate_parent_data(dev, name, parent_name, flags, reg,  \
> +#define clk_hw_register_gate_parent_data(dev, name, parent_data, flags, reg,  \
>                                        bit_idx, clk_gate_flags, lock)         \
> -       __clk_hw_register_gate((dev), NULL, (name), (parent_name), NULL,      \
> -                              NULL, (flags), (reg), (bit_idx),               \
> +       __clk_hw_register_gate((dev), NULL, (name), NULL, NULL, (parent_data) \

And this needs a comma after it.

I'll apply this to clk-fixes and send to Linus in the next few days.

> +                              (flags), (reg), (bit_idx),                     \
>                                (clk_gate_flags), (lock))