linux-kernel - Re: [PATCH] clk: Pass correct arguments to __clk_hw_register

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200325153200.6vdgglrirhpl4yh6@gilmour.lan>
Date:   Wed, 25 Mar 2020 16:32:00 +0100
From:   Maxime Ripard <maxime@...no.tech>
To:     Stephen Boyd <sboyd@...nel.org>
Cc:     Michael Turquette <mturquette@...libre.com>,
        linux-kernel@...r.kernel.org, linux-clk@...r.kernel.org
Subject: Re: [PATCH] clk: Pass correct arguments to __clk_hw_register_gate()

On Tue, Mar 24, 2020 at 07:28:12PM -0700, Stephen Boyd wrote:
> Quoting Stephen Boyd (2020-03-24 19:22:57)
> > diff --git a/include/linux/clk-provider.h b/include/linux/clk-provider.h
> > index 952ac035bab9..95cc8a4f6e39 100644
> > --- a/include/linux/clk-provider.h
> > +++ b/include/linux/clk-provider.h
> > @@ -539,10 +539,10 @@ struct clk *clk_register_gate(struct device *dev, const char *name,
> >   * @clk_gate_flags: gate-specific flags for this clock
> >   * @lock: shared register lock for this clock
> >   */
> > -#define clk_hw_register_gate_parent_data(dev, name, parent_name, flags, reg,  \
> > +#define clk_hw_register_gate_parent_data(dev, name, parent_data, flags, reg,  \
> >                                        bit_idx, clk_gate_flags, lock)         \
> > -       __clk_hw_register_gate((dev), NULL, (name), (parent_name), NULL,      \
> > -                              NULL, (flags), (reg), (bit_idx),               \
> > +       __clk_hw_register_gate((dev), NULL, (name), NULL, NULL, (parent_data) \
>
> And this needs a comma after it.
>
> I'll apply this to clk-fixes and send to Linus in the next few days.

With that fix,
Tested-by: Maxime Ripard <mripard@...nel.org>

Maxime

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)