linux-kernel - Re: [PATCH 2/3] kselftest: Extend vDSO selftest

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <281cc0c3-dbe3-2c39-3964-ce1147af9933@arm.com>
Date:   Wed, 25 Mar 2020 13:44:18 +0000
From:   Vincenzo Frascino <vincenzo.frascino@....com>
To:     Andy Lutomirski <luto@...nel.org>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        "open list:KERNEL SELFTEST FRAMEWORK" 
        <linux-kselftest@...r.kernel.org>, Shuah Khan <shuah@...nel.org>,
        Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [PATCH 2/3] kselftest: Extend vDSO selftest

Hi Andy,

On 3/24/20 5:22 PM, Andy Lutomirski wrote:
> On Tue, Mar 24, 2020 at 7:51 AM Vincenzo Frascino
> <vincenzo.frascino@....com> wrote:
>>
>> The current version of the multiarch vDSO selftest verifies only
>> gettimeofday.
>>
>> Extend the vDSO selftest to the other library functions:
>>  - time
>>  - clock_getres
>>  - clock_gettime
>>
>> The extension has been used to verify the unified vdso library on the
>> supported architectures.
> 
> The code in tools/testing/selftests/x86/test_vdso.c actually checks
> that the times returned by the vDSO are correct.  Perhaps that code
> should be copied or moved here?
> 

Good point. I was not aware of such a test. I will definitely move it here and
make sure it works for non x86 platforms as well in the next iteration of this
series.

-- 
Regards,
Vincenzo