linux-kernel - Re: [PATCH v6 09/10] power: supply: Support ROHM bd99954 charger

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <57ef569e704eaebfd4a83a29c51c75eb1c1f3438.camel@fi.rohmeurope.com>
Date:   Wed, 25 Mar 2020 13:47:28 +0000
From:   "Vaittinen, Matti" <Matti.Vaittinen@...rohmeurope.com>
To:     "andriy.shevchenko@...ux.intel.com" 
        <andriy.shevchenko@...ux.intel.com>
CC:     "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "dan.j.williams@...el.com" <dan.j.williams@...el.com>,
        "tglx@...utronix.de" <tglx@...utronix.de>,
        "brendanhiggins@...gle.com" <brendanhiggins@...gle.com>,
        "olteanv@...il.com" <olteanv@...il.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "talgi@...lanox.com" <talgi@...lanox.com>,
        "linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "davidgow@...gle.com" <davidgow@...gle.com>,
        "broonie@...nel.org" <broonie@...nel.org>,
        "herbert@...dor.apana.org.au" <herbert@...dor.apana.org.au>,
        "lgirdwood@...il.com" <lgirdwood@...il.com>,
        "rdunlap@...radead.org" <rdunlap@...radead.org>,
        "mark.rutland@....com" <mark.rutland@....com>,
        "yamada.masahiro@...ionext.com" <yamada.masahiro@...ionext.com>,
        "Mutanen, Mikko" <Mikko.Mutanen@...rohmeurope.com>,
        "bp@...e.de" <bp@...e.de>,
        "mhiramat@...nel.org" <mhiramat@...nel.org>,
        "krzk@...nel.org" <krzk@...nel.org>,
        "mazziesaccount@...il.com" <mazziesaccount@...il.com>,
        "skhan@...uxfoundation.org" <skhan@...uxfoundation.org>,
        "zaslonko@...ux.ibm.com" <zaslonko@...ux.ibm.com>,
        "Laine, Markus" <Markus.Laine@...rohmeurope.com>,
        "vincenzo.frascino@....com" <vincenzo.frascino@....com>,
        "sre@...nel.org" <sre@...nel.org>,
        "ardb@...nel.org" <ardb@...nel.org>,
        "linus.walleij@...aro.org" <linus.walleij@...aro.org>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "uwe@...ine-koenig.org" <uwe@...ine-koenig.org>,
        "akpm@...ux-foundation.org" <akpm@...ux-foundation.org>
Subject: Re: [PATCH v6 09/10] power: supply: Support ROHM bd99954 charger

Thanks for the patience Andy,

On Wed, 2020-03-25 at 15:21 +0200, andriy.shevchenko@...ux.intel.com
wrote:
> On Wed, Mar 25, 2020 at 03:20:33PM +0200, 
> andriy.shevchenko@...ux.intel.com wrote:
> > On Wed, Mar 25, 2020 at 01:00:21PM +0000, Vaittinen, Matti wrote:
> > But why?
> > 
> > You really uglify the code with ifdeffery, make a dependency to OF
> > (yes, you
> > will have to have of.h include) only because of that silly
> > macro and save 64 bytes of memory footprint.
> 
> And on top of that for !OF configuration you prevent your driver to
> be usable.
> (Consider PRP0001 ACPI case, for example)
> 

And here I revealed my ignorance what comes to ACPI world :) I didn't
know there is a way to utilize DT compatibles from ACPI.

Another mistake I did was assuming that the of_device_id would reside
in of.h. Thanks for the guidance - I do agree with you. I'll drop both
the ifdef and of_match_ptr().

Br,
	Matti