linux-kernel - Re: [PATCH] x86/smpboot: Remove 486-isms from the modern AP boot path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87r1xgxzy6.fsf@nanos.tec.linutronix.de>
Date:   Wed, 25 Mar 2020 15:37:53 +0100
From:   Thomas Gleixner <tglx@...utronix.de>
To:     hpa@...or.com, Andrew Cooper <andrew.cooper3@...rix.com>,
        LKML <linux-kernel@...r.kernel.org>
Cc:     Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
        x86@...nel.org, Jan Kiszka <jan.kiszka@...mens.com>,
        James Morris <jmorris@...ei.org>,
        David Howells <dhowells@...hat.com>,
        Matthew Garrett <mjg59@...gle.com>,
        Josh Boyer <jwboyer@...hat.com>,
        Zhenzhong Duan <zhenzhong.duan@...cle.com>,
        Steve Wahl <steve.wahl@....com>,
        Mike Travis <mike.travis@....com>,
        Dimitri Sivanich <dimitri.sivanich@....com>,
        Arnd Bergmann <arnd@...db.de>,
        "Peter Zijlstra \(Intel\)" <peterz@...radead.org>,
        Giovanni Gherdovich <ggherdovich@...e.cz>,
        "Rafael J. Wysocki" <rafael.j.wysocki@...el.com>,
        Len Brown <len.brown@...el.com>,
        Kees Cook <keescook@...omium.org>,
        Martin Molnar <martin.molnar.programming@...il.com>,
        Pingfan Liu <kernelfans@...il.com>,
        jailhouse-dev@...glegroups.com
Subject: Re: [PATCH] x86/smpboot: Remove 486-isms from the modern AP boot path

hpa@...or.com writes:
> On March 25, 2020 3:14:31 AM PDT, Andrew Cooper <andrew.cooper3@...rix.com> wrote:
>>@@ -1118,7 +1121,7 @@ static int do_boot_cpu(int apicid, int cpu,
>>struct task_struct *idle,
>> 		}
>> 	}
>> 
>>-	if (x86_platform.legacy.warm_reset) {
>>+	if (!APIC_INTEGRATED(boot_cpu_apic_version)) {
>> 		/*
>> 		 * Cleanup possible dangling ends...
>> 		 */
>
> We don't support SMP on 486 and haven't for a very long time. Is there
> any reason to retain that code at all?

Not that I'm aware off.

Thanks,

        tglx