lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 27 Mar 2020 10:25:04 +0000 From: Shane Francis <bigbeeshane@...il.com> To: Marek Szyprowski <m.szyprowski@...sung.com> Cc: Maling list - DRI developers <dri-devel@...ts.freedesktop.org>, linux-samsung-soc@...r.kernel.org, linux-kernel@...r.kernel.org, stable@...r.kernel.org, Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>, Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>, Maxime Ripard <mripard@...nel.org>, Thomas Zimmermann <tzimmermann@...e.de>, David Airlie <airlied@...ux.ie>, Daniel Vetter <daniel@...ll.ch>, Alex Deucher <alexander.deucher@....com>, "Michael J . Ruhl" <michael.j.ruhl@...el.com> Subject: Re: [PATCH] drm/prime: fix extracting of the DMA addresses from a scatterlist Hello Marek, On Fri, Mar 27, 2020 at 9:00 AM Marek Szyprowski <m.szyprowski@...sung.com> wrote: > > I have tested the above patch against my original issues with amdgpu > > and radeon drivers and everything is still working as expected. > > > > Sorry I missed this in my original patches. > > No problem. Thanks for testing! > > Best regards > -- > Marek Szyprowski, PhD > Samsung R&D Institute Poland > Just a thought. Would it be worth adding some comments to the code to explain why this is needed, reading the thread around my original patches and the DMA-API documentation it is not instantly clear why you would be mapping the pages in this way. Would probably prevent someone in the future making the same mistake I did while updating this code. Regards, Shane Francis
Powered by blists - more mailing lists