linux-kernel - Re: [PATCH] sched/fair: Fix negative imbalance in imbalance calculation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200327114801.GL3772@suse.de>
Date:   Fri, 27 Mar 2020 11:48:01 +0000
From:   Mel Gorman <mgorman@...e.de>
To:     Aubrey Li <aubrey.li@...el.com>
Cc:     vincent.guittot@...aro.org, mingo@...hat.com, peterz@...radead.org,
        juri.lelli@...hat.com, dietmar.eggemann@....com,
        rostedt@...dmis.org, bsegall@...gle.com,
        linux-kernel@...r.kernel.org, tim.c.chen@...ux.intel.com,
        vpillai@...italocean.com, joel@...lfernandes.org,
        Aubrey Li <aubrey.li@...ux.intel.com>,
        Phil Auld <pauld@...hat.com>
Subject: Re: [PATCH] sched/fair: Fix negative imbalance in imbalance
 calculation

On Thu, Mar 26, 2020 at 01:42:29PM +0800, Aubrey Li wrote:
> A negative imbalance value was observed after imbalance calculation,
> this happens when the local sched group type is group_fully_busy,
> and the average load of local group is greater than the selected
> busiest group. Fix this problem by comparing the average load of the
> local and busiest group before imbalance calculation formula.
> 
> Suggested-by: Vincent Guittot <vincent.guittot@...aro.org>
> Signed-off-by: Aubrey Li <aubrey.li@...ux.intel.com>
> Cc: Phil Auld <pauld@...hat.com>

Acked-by: Mel Gorman <mgorman@...e.de>

-- 
Mel Gorman
SUSE Labs