linux-kernel - Re: [PATCH] sched/fair: Fix negative imbalance in imbalance calculation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200330103838.GE20696@hirez.programming.kicks-ass.net>
Date:   Mon, 30 Mar 2020 12:38:38 +0200
From:   Peter Zijlstra <peterz@...radead.org>
To:     Vincent Guittot <vincent.guittot@...aro.org>
Cc:     Aubrey Li <aubrey.li@...el.com>, Ingo Molnar <mingo@...hat.com>,
        Juri Lelli <juri.lelli@...hat.com>,
        Dietmar Eggemann <dietmar.eggemann@....com>,
        Steven Rostedt <rostedt@...dmis.org>,
        Ben Segall <bsegall@...gle.com>, Mel Gorman <mgorman@...e.de>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        Tim Chen <tim.c.chen@...ux.intel.com>,
        Vineeth Pillai <vpillai@...italocean.com>,
        Joel Fernandes <joel@...lfernandes.org>,
        Aubrey Li <aubrey.li@...ux.intel.com>,
        Phil Auld <pauld@...hat.com>
Subject: Re: [PATCH] sched/fair: Fix negative imbalance in imbalance
 calculation

On Thu, Mar 26, 2020 at 05:03:10PM +0100, Vincent Guittot wrote:
> On Thu, 26 Mar 2020 at 06:53, Aubrey Li <aubrey.li@...el.com> wrote:
> >
> > A negative imbalance value was observed after imbalance calculation,
> > this happens when the local sched group type is group_fully_busy,
> > and the average load of local group is greater than the selected
> > busiest group. Fix this problem by comparing the average load of the
> > local and busiest group before imbalance calculation formula.
> >
> > Suggested-by: Vincent Guittot <vincent.guittot@...aro.org>
> > Signed-off-by: Aubrey Li <aubrey.li@...ux.intel.com>
> > Cc: Phil Auld <pauld@...hat.com>
> 
> Reviewed-by: Vincent Guittot <vincent.guittot@...aro.org>

Thanks!