linux-kernel - [PATCH][next] btrfs: inode: Fix uninitialized variable bug

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200327200135.GA3472@embeddedor>
Date:   Fri, 27 Mar 2020 15:01:35 -0500
From:   "Gustavo A. R. Silva" <gustavo@...eddedor.com>
To:     Chris Mason <clm@...com>, Josef Bacik <josef@...icpanda.com>,
        David Sterba <dsterba@...e.com>
Cc:     linux-btrfs@...r.kernel.org, linux-kernel@...r.kernel.org,
        "Gustavo A. R. Silva" <gustavo@...eddedor.com>
Subject: [PATCH][next] btrfs: inode: Fix uninitialized variable bug

geom.len is being used without being properly initialized, previously.

Fix this by placing ASSERT(geom.len <= INT_MAX); after geom.len has been
initialized.

Addresses-Coverity-ID: 1491912 ("Uninitialized scalar variable")
Fixes: 1eb52c8bd8d6 ("btrfs: get rid of one layer of bios in direct I/O")
Signed-off-by: Gustavo A. R. Silva <gustavo@...eddedor.com>
---
 fs/btrfs/inode.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/fs/btrfs/inode.c b/fs/btrfs/inode.c
index fce94591e092..00ea02268f54 100644
--- a/fs/btrfs/inode.c
+++ b/fs/btrfs/inode.c
@@ -7637,7 +7637,6 @@ static void btrfs_submit_direct_hook(struct btrfs_dio_private *dip)
 	else
 		async_submit = 1;
 
-	ASSERT(geom.len <= INT_MAX);
 	do {
 		ret = btrfs_get_io_geometry(fs_info, btrfs_op(dio_bio),
 					    start_sector << 9, submit_len,
@@ -7647,6 +7646,8 @@ static void btrfs_submit_direct_hook(struct btrfs_dio_private *dip)
 			goto out_err;
 		}
 
+		ASSERT(geom.len <= INT_MAX);
+
 		clone_len = min_t(int, submit_len, geom.len);
 
 		/*
-- 
2.26.0