linux-kernel - Re: [PATCH][next] btrfs: inode: Fix uninitialized variable bug

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200401160050.GV5920@twin.jikos.cz>
Date:   Wed, 1 Apr 2020 18:00:50 +0200
From:   David Sterba <dsterba@...e.cz>
To:     "Gustavo A. R. Silva" <gustavo@...eddedor.com>, osandov@...com
Cc:     Chris Mason <clm@...com>, Josef Bacik <josef@...icpanda.com>,
        David Sterba <dsterba@...e.com>, linux-btrfs@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH][next] btrfs: inode: Fix uninitialized variable bug

On Fri, Mar 27, 2020 at 03:01:35PM -0500, Gustavo A. R. Silva wrote:
> geom.len is being used without being properly initialized, previously.
> 
> Fix this by placing ASSERT(geom.len <= INT_MAX); after geom.len has been
> initialized.
> 
> Addresses-Coverity-ID: 1491912 ("Uninitialized scalar variable")
> Fixes: 1eb52c8bd8d6 ("btrfs: get rid of one layer of bios in direct I/O")

Thanks.  This is in a development branch so the fixup can be folded in,
we're expecting more revisions of the patchset anyway. CCing Omar.