linux-kernel - Re: [PATCH 01/10] locking/rtmutex: Remove Comparison to bool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87y2rkwwf5.fsf@nanos.tec.linutronix.de>
Date:   Sat, 28 Mar 2020 12:28:30 +0100
From:   Thomas Gleixner <tglx@...utronix.de>
To:     Jules Irenge <jbi.octave@...il.com>, julia.lawall@...6.fr
Cc:     boqun.feng@...il.com, Jules Irenge <jbi.octave@...mple.com>,
        Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...hat.com>, Will Deacon <will@...nel.org>,
        "open list\:LOCKING PRIMITIVES" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 01/10] locking/rtmutex: Remove Comparison to bool

Jules Irenge <jbi.octave@...il.com> writes:

> From: Jules Irenge <jbi.octave@...mple.com>
>
> Coccinelle reports a warning inside rt_mutex_slowunlock()
>
> WARNING: Comparison to bool
>
> To fix this, the comparison to bool is removed
> This not only fixes the issue but also removes the unnecessary comparison.
>
> Remove comparison to bool

So you explain 3 times in different ways that the comparison to bool is
removed. What's the point?

Thanks,

        tglx