linux-kernel - Re: [PATCH 01/10] locking/rtmutex: Remove Comparison to bool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LNX.2.21.1.2003281201270.20453@ninjahost.lan>
Date:   Sat, 28 Mar 2020 12:02:14 +0000 (GMT)
From:   Jules Irenge <jbi.octave@...il.com>
To:     Thomas Gleixner <tglx@...utronix.de>
cc:     Jules Irenge <jbi.octave@...il.com>, julia.lawall@...6.fr,
        boqun.feng@...il.com, Jules Irenge <jbi.octave@...mple.com>,
        Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...hat.com>, Will Deacon <will@...nel.org>,
        "open list:LOCKING PRIMITIVES" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 01/10] locking/rtmutex: Remove Comparison to bool



On Sat, 28 Mar 2020, Thomas Gleixner wrote:

> Jules Irenge <jbi.octave@...il.com> writes:
> 
> > From: Jules Irenge <jbi.octave@...mple.com>
> >
> > Coccinelle reports a warning inside rt_mutex_slowunlock()
> >
> > WARNING: Comparison to bool
> >
> > To fix this, the comparison to bool is removed
> > This not only fixes the issue but also removes the unnecessary comparison.
> >
> > Remove comparison to bool
> 
> So you explain 3 times in different ways that the comparison to bool is
> removed. What's the point?
> 
> Thanks,
> 
>         tglx
> 
> 
> 
Thanks for the feedback I take good note. I will improve next time.