linux-kernel - Re: [PATCH] net: dsa: Simplify 'dsa_tag_protocol_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200328154424.GW3819@lunn.ch>
Date:   Sat, 28 Mar 2020 16:44:24 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Christophe JAILLET <christophe.jaillet@...adoo.fr>
Cc:     vivien.didelot@...il.com, davem@...emloft.net, kuba@...nel.org,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] net: dsa: Simplify 'dsa_tag_protocol_to_str()'

On Sat, Mar 28, 2020 at 10:53:09AM +0100, Christophe JAILLET wrote:
> There is no point in preparing the module name in a buffer. The format
> string can be passed diectly to 'request_module()'.
> 
> This axes a few lines of code and cleans a few things:
>    - max len for a driver name is MODULE_NAME_LEN wich is ~ 60 chars,
>      not 128. It would be down-sized in 'request_module()'
>    - we should pass the total size of the buffer to 'snprintf()', not the
>      size minus 1
> 
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew