linux-kernel - Re: [PATCH v3 2/2] mm: mmap: add trace point of vm_unmapped

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200329160858.GV22483@bombadil.infradead.org>
Date:   Sun, 29 Mar 2020 09:08:58 -0700
From:   Matthew Wilcox <willy@...radead.org>
To:     Jaewon Kim <jaewon31.kim@...sung.com>
Cc:     walken@...gle.com, bp@...e.de, akpm@...ux-foundation.org,
        srostedt@...are.com, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org, jaewon31.kim@...il.com
Subject: Re: [PATCH v3 2/2] mm: mmap: add trace point of vm_unmapped_area

On Fri, Mar 20, 2020 at 02:58:23PM +0900, Jaewon Kim wrote:
> +	TP_printk("addr=%lx err=%ld total_vm=0x%lx flags=0x%lx len=0x%lx lo=0x%lx hi=0x%lx mask=0x%lx ofs=0x%lx\n",

Shouldn't addr be printed as 0x%lx?  I think it's arguable whether to print
len as %ld or 0x%lx.