linux-kernel - [PATCH] signal: use kill_proc_info instead of kill_pid_info in kill_something

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <80236965-f0b5-c888-95ff-855bdec75bb3@huawei.com>
Date:   Mon, 30 Mar 2020 10:44:43 +0800
From:   Zhiqiang Liu <liuzhiqiang26@...wei.com>
To:     <ebiederm@...ssion.com>, <oleg@...hat.com>,
        <christian.brauner@...ntu.com>, <tj@...nel.org>,
        <akpm@...ux-foundation.org>, <guro@...com>,
        <joel@...lfernandes.org>, <linux-kernel@...r.kernel.org>
CC:     Mingfangsen <mingfangsen@...wei.com>,
        linfeilong <linfeilong@...wei.com>, <liuzhiqiang26@...wei.com>
Subject: [PATCH] signal: use kill_proc_info instead of kill_pid_info in
 kill_something_info


signal.c provides kill_proc_info, we can use it instead of kill_pid_info
in kill_something_info func gracefully.

Signed-off-by: Zhiqiang Liu <liuzhiqiang26@...wei.com>
---
 kernel/signal.c | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/kernel/signal.c b/kernel/signal.c
index 9ad8dea93dbb..33c70f9f1728 100644
--- a/kernel/signal.c
+++ b/kernel/signal.c
@@ -1552,12 +1552,8 @@ static int kill_something_info(int sig, struct kernel_siginfo *info, pid_t pid)
 {
 	int ret;

-	if (pid > 0) {
-		rcu_read_lock();
-		ret = kill_pid_info(sig, info, find_vpid(pid));
-		rcu_read_unlock();
-		return ret;
-	}
+	if (pid > 0)
+		return kill_proc_info(sig, info, pid);

 	/* -INT_MIN is undefined.  Exclude this case to avoid a UBSAN warning */
 	if (pid == INT_MIN)
-- 
2.19.1