linux-kernel - Re: [PATCH] signal: use kill_proc_info instead of kill_pid_info in kill_something

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200330084632.GA13298@redhat.com>
Date:   Mon, 30 Mar 2020 10:46:33 +0200
From:   Oleg Nesterov <oleg@...hat.com>
To:     Zhiqiang Liu <liuzhiqiang26@...wei.com>
Cc:     ebiederm@...ssion.com, christian.brauner@...ntu.com, tj@...nel.org,
        akpm@...ux-foundation.org, guro@...com, joel@...lfernandes.org,
        linux-kernel@...r.kernel.org, Mingfangsen <mingfangsen@...wei.com>,
        linfeilong <linfeilong@...wei.com>
Subject: Re: [PATCH] signal: use kill_proc_info instead of kill_pid_info in
 kill_something_info

On 03/30, Zhiqiang Liu wrote:
>
> @@ -1552,12 +1552,8 @@ static int kill_something_info(int sig, struct kernel_siginfo *info, pid_t pid)
>  {
>  	int ret;
> 
> -	if (pid > 0) {
> -		rcu_read_lock();
> -		ret = kill_pid_info(sig, info, find_vpid(pid));
> -		rcu_read_unlock();
> -		return ret;
> -	}
> +	if (pid > 0)
> +		return kill_proc_info(sig, info, pid);
> 

Acked-by: Oleg Nesterov <oleg@...hat.com>