linux-kernel - Re: [PATCH] mtd:clear cache_state to avoid writing to bad clocks repeatedly

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 30 Mar 2020 16:44:29 +0800
From:   Xiaoming Ni <nixiaoming@...wei.com>
To:     Miquel Raynal <miquel.raynal@...tlin.com>
CC:     <richard@....at>, <vigneshr@...com>,
        <linux-mtd@...ts.infradead.org>, <linux-kernel@...r.kernel.org>,
        <wangle6@...wei.com>, <zhangweimin12@...wei.com>,
        <yebin10@...wei.com>, <houtao1@...wei.com>
Subject: Re: [PATCH] mtd:clear cache_state to avoid writing to bad clocks
 repeatedly

On 2020/3/30 15:53, Miquel Raynal wrote:
> Hi Xiaoming,
> 
> Xiaoming Ni <nixiaoming@...wei.com> wrote on Sat, 28 Mar 2020 21:01:17
> +0800:
> 
>> The function call process is as follows:
>> 	mtd_blktrans_work()
>> 	  while (1)
....

>> +	 *
>> +	 * if this cache_offset points to a bad block
> 
> Can you start your sentences with a capital letter please?
> 
> 	 * If
> 
>> +	 * data cannot be written to the device.
>> +	 * clear cache_state to avoid writing to bad clocks repeatedly
> 
> 	 * Clear
> 
> And also please break your lines à 80, not 70.
> 
>>   	 */
>> -	mtdblk->cache_state = STATE_EMPTY;
>> -	return 0;
>> +	if (ret == 0 || ret == -EIO)
>> +		mtdblk->cache_state = STATE_EMPTY;
Should I add a warning print for EIO here


>> +	return ret;
>>   }
>>   
>>   
> 
> Otherwise looks good to me.
> 
> With the above addressed:
> 
> Reviewed-by: Miquel Raynal <miquel.raynal@...tlin.com>
> 
> 
> Thanks,
> Miquèl
> 
> .

Thanks for your advice, I will send v2 patch later

Thanks,
Xiaoming Ni