[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20200330104741.2f48378d@xps13>
Date: Mon, 30 Mar 2020 10:47:41 +0200
From: Miquel Raynal <miquel.raynal@...tlin.com>
To: Xiaoming Ni <nixiaoming@...wei.com>
Cc: <richard@....at>, <vigneshr@...com>,
<linux-mtd@...ts.infradead.org>, <linux-kernel@...r.kernel.org>,
<wangle6@...wei.com>, <zhangweimin12@...wei.com>,
<yebin10@...wei.com>, <houtao1@...wei.com>
Subject: Re: [PATCH] mtd:clear cache_state to avoid writing to bad clocks
repeatedly
Hi Xiaoming,
Xiaoming Ni <nixiaoming@...wei.com> wrote on Mon, 30 Mar 2020 16:44:29
+0800:
> On 2020/3/30 15:53, Miquel Raynal wrote:
> > Hi Xiaoming,
> >
> > Xiaoming Ni <nixiaoming@...wei.com> wrote on Sat, 28 Mar 2020 21:01:17
> > +0800:
> >
> >> The function call process is as follows:
> >> mtd_blktrans_work()
> >> while (1)
> ....
>
> >> + *
> >> + * if this cache_offset points to a bad block
> >
> > Can you start your sentences with a capital letter please?
> >
> > * If
> >
> >> + * data cannot be written to the device.
> >> + * clear cache_state to avoid writing to bad clocks repeatedly
> >
> > * Clear
> >
> > And also please break your lines à 80, not 70.
> >
> >> */
> >> - mtdblk->cache_state = STATE_EMPTY;
> >> - return 0;
> >> + if (ret == 0 || ret == -EIO)
> >> + mtdblk->cache_state = STATE_EMPTY;
> Should I add a warning print for EIO here
I don't think so.
Thanks,
Miquèl
Powered by blists - more mailing lists