linux-kernel - Re: [PATCH 5/9] power: supply: smb347-charger: Implement device-tree support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <44ab265e-4a67-bc26-d931-ca7d155171a2@gmail.com>
Date:   Tue, 31 Mar 2020 20:20:58 +0300
From:   Dmitry Osipenko <digetx@...il.com>
To:     Jonghwa Lee <jonghwa3.lee@...sung.com>,
        David Heidelberg <david@...t.cz>,
        Sebastian Reichel <sre@...nel.org>,
        Chanwoo Choi <cw00.choi@...sung.com>,
        Myungjoo Ham <myungjoo.ham@...sung.com>,
        Sumit Semwal <sumit.semwal@...aro.org>,
        John Stultz <john.stultz@...aro.org>,
        Vinay Simha BN <simhavcs@...il.com>,
        mika.westerberg@...ux.intel.com, ramakrishna.pallala@...el.com,
        linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 5/9] power: supply: smb347-charger: Implement device-tree
 support

Hello Jonghwa,

31.03.2020 03:25, Jonghwa Lee пишет:
> On 20. 3. 30. 오전 1:21, David Heidelberg wrote:
>> This patch makes smb347 charger driver to support dt binding. All legacy
>> platform data now can be parsed from dt.
>> Because of that smb347 is i2c client driver, IRQ number can be passed
>> automatically through client's irq variable if it is defined in dt.
>> No more to use requesting gpio to irq manually in dt-way.
> Thanks for keeping original commit description and revealing where it 
> comes from.
> 
> Anyway, in the above description, the last three lines doesn't match to 
> the commit since
> 
> the original patch is now split. Please remove them or you can rewrite 
> description as your own.

That's a good suggestion, thank you very much.