[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20200331215800.GA12799@bogus>
Date: Tue, 31 Mar 2020 15:58:00 -0600
From: Rob Herring <robh@...nel.org>
To: frowand.list@...il.com
Cc: pantelis.antoniou@...sulko.com, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org,
Geert Uytterhoeven <geert+renesas@...der.be>,
Alan Tull <atull@...nel.org>
Subject: Re: [PATCH 2/2] of: some unittest overlays not untracked
On Wed, 25 Mar 2020 20:45:31 -0500, frowand.list@...il.com wrote:
> From: Frank Rowand <frank.rowand@...y.com>
>
> kernel test robot reported "WARNING: held lock freed!" triggered by
> unittest_gpio_remove(), which should not have been called because
> the related gpio overlay was not tracked. Another overlay that
> was tracked had previously used the same id as the gpio overlay
> but had not been untracked when the overlay was removed. Thus the
> clean up function of_unittest_destroy_tracked_overlays() incorrectly
> attempted to remove the reused overlay id.
>
> Patch contents:
>
> - Create tracking related helper functions
> - Change BUG() to WARN_ON() for overlay id related issues
> - Add some additional error checking for valid overlay id values
> - Add the missing overlay untrack
> - update comment on expectation that overlay ids are assigned in
> sequence
>
> Fixes: 492a22aceb75 ("of: unittest: overlay: Keep track of created overlays")
> Reported-by: kernel test robot <lkp@...el.com>
> Signed-off-by: Frank Rowand <frank.rowand@...y.com>
> ---
> drivers/of/unittest.c | 30 +++++++++++++++++++++++-------
> 1 file changed, 23 insertions(+), 7 deletions(-)
>
Applied, thanks.
Rob
Powered by blists - more mailing lists