linux-kernel - Re: [PATCH 1/4] soc: mediatek: Enable mmsys driver by default if Mediatek arch is selected

Open Source and information security mailing list archives

Message-ID: <CAAOTY_-=y+t1tDnV_muYs9KS_-mQK9UtRzHe_O1AnStB1XqrLg@mail.gmail.com>
Date:   Wed, 1 Apr 2020 07:21:20 +0800
From:   Chun-Kuang Hu <chunkuang.hu@...nel.org>
To:     Enric Balletbo i Serra <enric.balletbo@...labora.com>
Cc:     Mark Rutland <mark.rutland@....com>, CK Hu <ck.hu@...iatek.com>,
        Stephen Boyd <sboyd@...nel.org>,
        ulrich.hecht+renesas@...il.com,
        Matthias Brugger <mbrugger@...e.com>, hsinyi@...omium.org,
        linux-kernel@...r.kernel.org,
        Nicolas Boichat <drinkcat@...omium.org>,
        linux-mediatek@...ts.infradead.org, matthias.bgg@...nel.org,
        Matthias Brugger <matthias.bgg@...il.com>,
        Collabora Kernel ML <kernel@...labora.com>,
        linux-clk@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH 1/4] soc: mediatek: Enable mmsys driver by default if
 Mediatek arch is selected

Hi, Enric:

Enric Balletbo i Serra <enric.balletbo@...labora.com> 於 2020年4月1日 週三 上午5:46寫道：
>
> The mmsys driver supports only MT8173 device for now, but like other system
> controllers is an important piece for other Mediatek devices. Actually
> it depends on the mt8173 clock specific driver but that dependency is
> not real as it can build without the clock driver. Instead of depends on
> a specific model, make the driver depends on the generic ARCH_MEDIATEK and
> enable by default so other Mediatek devices can start using it without
> flood the Kconfig.

I've no idea about 'enable by default'. For some product which has no
display, it does not need mmsys partition (include drm and mdp). But
the code size of mmsys is not large, so it seems enable it by default
has no harm. Just provide some information for you.

Regards,
Chun-Kuang.

>
> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@...labora.com>
> ---
>
>  drivers/soc/mediatek/Kconfig | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/soc/mediatek/Kconfig b/drivers/soc/mediatek/Kconfig
> index e84513318725..59a56cd790ec 100644
> --- a/drivers/soc/mediatek/Kconfig
> +++ b/drivers/soc/mediatek/Kconfig
> @@ -46,8 +46,7 @@ config MTK_SCPSYS
>
>  config MTK_MMSYS
>         bool "MediaTek MMSYS Support"
> -       depends on COMMON_CLK_MT8173_MMSYS
> -       default COMMON_CLK_MT8173_MMSYS
> +       default ARCH_MEDIATEK
>         help
>           Say yes here to add support for the MediaTek Multimedia
>           Subsystem (MMSYS).
> --
> 2.25.1
>
>
> _______________________________________________
> Linux-mediatek mailing list
> Linux-mediatek@...ts.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-mediatek

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives