linux-kernel - Re: [PATCH v8 11/14] KVM: selftests: Introduce after_vcpu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200401232421.GA7174@xz-x1>
Date:   Wed, 1 Apr 2020 19:24:21 -0400
From:   Peter Xu <peterx@...hat.com>
To:     Andrew Jones <drjones@...hat.com>
Cc:     linux-kernel@...r.kernel.org, kvm@...r.kernel.org,
        Kevin Tian <kevin.tian@...el.com>,
        "Michael S . Tsirkin" <mst@...hat.com>,
        Jason Wang <jasowang@...hat.com>,
        Sean Christopherson <sean.j.christopherson@...el.com>,
        Christophe de Dinechin <dinechin@...hat.com>,
        Yan Zhao <yan.y.zhao@...el.com>,
        Alex Williamson <alex.williamson@...hat.com>,
        Paolo Bonzini <pbonzini@...hat.com>,
        Vitaly Kuznetsov <vkuznets@...hat.com>,
        "Dr . David Alan Gilbert" <dgilbert@...hat.com>
Subject: Re: [PATCH v8 11/14] KVM: selftests: Introduce after_vcpu_run hook
 for dirty log test

On Wed, Apr 01, 2020 at 09:03:22AM +0200, Andrew Jones wrote:
> On Tue, Mar 31, 2020 at 02:59:57PM -0400, Peter Xu wrote:
> > Provide a hook for the checks after vcpu_run() completes.  Preparation
> > for the dirty ring test because we'll need to take care of another
> > exit reason.
> > 
> > Since at it, drop the pages_count because after all we have a better
> > summary right now with statistics, and clean it up a bit.
> 
> I don't see what you mean by "drop the pages_count", because it's still
> there. But otherwise
> 
> Reviewed-by: Andrew Jones <drjones@...hat.com>

I think the pages_count was dropped in some versions, at least the 1st
version when I wrote the commit, but it must have went back during one
of the rebases upon dirty_log_test.c...  To make it simple, I'll just
remove this paragraph and pick the r-b (assuming it's valid with that).

Thanks,

-- 
Peter Xu