[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20200402045008.GB11124@qmqm.qmqm.pl>
Date: Thu, 2 Apr 2020 06:50:08 +0200
From: Michał Mirosław <mirq-linux@...e.qmqm.pl>
To: Dmitry Osipenko <digetx@...il.com>
Cc: Rob Herring <robh+dt@...nel.org>,
Thierry Reding <thierry.reding@...il.com>,
Jonathan Hunter <jonathanh@...dia.com>,
David Heidelberg <david@...t.cz>,
Peter Geis <pgwipeout@...il.com>,
Stephen Warren <swarren@...dotorg.org>,
Nicolas Chauvet <kwizart@...il.com>,
Pedro Ângelo <pangelo@...d.io>,
Matt Merhar <mattmerhar@...tonmail.com>,
linux-tegra@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1 5/6] dt-bindings: ARM: tegra: Add ASUS Google Nexus 7
On Wed, Apr 01, 2020 at 12:43:26AM +0300, Dmitry Osipenko wrote:
> Add a binding for the Tegra30-based ASUS Google Nexus 7 tablet device.
>
> Signed-off-by: Dmitry Osipenko <digetx@...il.com>
> ---
> Documentation/devicetree/bindings/arm/tegra.yaml | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/tegra.yaml b/Documentation/devicetree/bindings/arm/tegra.yaml
> index 7fd0b66c69b2..fb3bbf7a5fb4 100644
> --- a/Documentation/devicetree/bindings/arm/tegra.yaml
> +++ b/Documentation/devicetree/bindings/arm/tegra.yaml
> @@ -62,6 +62,13 @@ properties:
> - toradex,colibri_t30-eval-v3
> - const: toradex,colibri_t30
> - const: nvidia,tegra30
> + - items:
> + - const: asus,grouper
> + - const: nvidia,tegra30
> + - items:
> + - const: asus,tilapia
> + - const: asus,grouper
> + - const: nvidia,tegra30
> - items:
> - enum:
> - nvidia,dalmore
Is it really necessary to list every possible device using a SoC chip?
Wouldn't it be enough to just list SoC value nvidia,tegraXYZ and allow
any other supplemental "compatibles"?
Best Regards,
Michał Mirosław
Powered by blists - more mailing lists