linux-kernel - Re: [PATCH v1 5/6] dt-bindings: ARM: tegra: Add ASUS Google Nexus 7

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4c059f4a-111a-086b-c165-eb8ae798d606@gmail.com>
Date:   Thu, 2 Apr 2020 17:52:51 +0300
From:   Dmitry Osipenko <digetx@...il.com>
To:     Michał Mirosław <mirq-linux@...e.qmqm.pl>
Cc:     Rob Herring <robh+dt@...nel.org>,
        Thierry Reding <thierry.reding@...il.com>,
        Jonathan Hunter <jonathanh@...dia.com>,
        David Heidelberg <david@...t.cz>,
        Peter Geis <pgwipeout@...il.com>,
        Stephen Warren <swarren@...dotorg.org>,
        Nicolas Chauvet <kwizart@...il.com>,
        Pedro Ângelo <pangelo@...d.io>,
        Matt Merhar <mattmerhar@...tonmail.com>,
        linux-tegra@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1 5/6] dt-bindings: ARM: tegra: Add ASUS Google Nexus 7

02.04.2020 07:50, Michał Mirosław пишет:
> On Wed, Apr 01, 2020 at 12:43:26AM +0300, Dmitry Osipenko wrote:
>> Add a binding for the Tegra30-based ASUS Google Nexus 7 tablet device.
>>
>> Signed-off-by: Dmitry Osipenko <digetx@...il.com>
>> ---
>>  Documentation/devicetree/bindings/arm/tegra.yaml | 7 +++++++
>>  1 file changed, 7 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/arm/tegra.yaml b/Documentation/devicetree/bindings/arm/tegra.yaml
>> index 7fd0b66c69b2..fb3bbf7a5fb4 100644
>> --- a/Documentation/devicetree/bindings/arm/tegra.yaml
>> +++ b/Documentation/devicetree/bindings/arm/tegra.yaml
>> @@ -62,6 +62,13 @@ properties:
>>                - toradex,colibri_t30-eval-v3
>>            - const: toradex,colibri_t30
>>            - const: nvidia,tegra30
>> +      - items:
>> +          - const: asus,grouper
>> +          - const: nvidia,tegra30
>> +      - items:
>> +          - const: asus,tilapia
>> +          - const: asus,grouper
>> +          - const: nvidia,tegra30
>>        - items:
>>            - enum:
>>                - nvidia,dalmore
> 
> Is it really necessary to list every possible device using a SoC chip?

Yes, otherwise make dtbs_check will give you a warning about the unknown
compatible.

> Wouldn't it be enough to just list SoC value nvidia,tegraXYZ and allow
> any other supplemental "compatibles"?

I don't know what was the initial intention of having boards defined in
a way it's currently done, maybe Rob;Thierry;Stephen;Jon could clarify?