linux-kernel - Re: [GIT PULL] x86 cleanups for v5.7

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87sghmnvtv.fsf@nanos.tec.linutronix.de>
Date:   Thu, 02 Apr 2020 10:19:40 +0200
From:   Thomas Gleixner <tglx@...utronix.de>
To:     Linus Torvalds <torvalds@...ux-foundation.org>
Cc:     Ingo Molnar <mingo@...nel.org>, Al Viro <viro@...iv.linux.org.uk>,
        Andy Lutomirski <luto@...capital.net>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Borislav Petkov <bp@...en8.de>,
        Peter Zijlstra <a.p.zijlstra@...llo.nl>,
        Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [GIT PULL] x86 cleanups for v5.7

Linus Torvalds <torvalds@...ux-foundation.org> writes:
> On Wed, Apr 1, 2020 at 4:55 PM Thomas Gleixner <tglx@...utronix.de> wrote:
>>
>>   - x86 starts the short log after the colon with an uppercase
>>     letter
>
> Ahh. I actually tried to match the previous ones by Al, and they don't
> follow that pattern.

Yeah. As Al's stuff was late already, I just took it as is.

>>   - All commits lack a Link:https//lore.kernel.org/r/$MSG-ID tag. That
>>     might be an oversight or just reflecting the fact that these patches
>>     have never seen a mailing list.
>
> Yeah. They were literally me looking at my patch in my other tree, and
> trying to make incremental progress.
>
> Nobody else has a working compiler to even test that patch, because
> even upstream tip-of-the-day llvm mis-generates code (I have a patch
> that makes it generate ok code, but that one isn't good enough to
> actually go upstream in llvm).

Fair enough.

> I don't think I'll do any more, because the next stage really is to
> actually have some CONFIG_ASM_GOTO_WITH_INPUTS code and then try to
> make something similar to the SET_CC for this.
>
>> From a quick check I can confirm that the resulting text changes are
>> just random noise and I did not notice anything horrible in the
>> generated code either.
>
> Btw, do you guys have some better object code comparison thing than my
> "objdump plus a few sed scripts to hide code movement effects"

Not sure whether s/sed/python/ makes it any better :)

Thanks,

        tglx