linux-kernel - Re: [kbuild-all] Re: [RFC PATCH] usb: cdns3: cdns3_clear_register

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <556997e2-1921-e3dd-c103-d6e3c8f91888@intel.com>
Date:   Thu, 2 Apr 2020 09:33:46 +0800
From:   Rong Chen <rong.a.chen@...el.com>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     kbuild test robot <lkp@...el.com>,
        Colin King <colin.king@...onical.com>, kbuild-all@...ts.01.org,
        Sekhar Nori <nsekhar@...com>, Roger Quadros <rogerq@...com>,
        Felipe Balbi <felipe.balbi@...ux.intel.com>,
        Pawel Laszczak <pawell@...ence.com>, linux-usb@...r.kernel.org,
        kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [kbuild-all] Re: [RFC PATCH] usb: cdns3:
 cdns3_clear_register_bit() can be static



On 3/27/20 2:53 PM, Rong Chen wrote:
>
>
> On 3/27/20 2:42 PM, Greg Kroah-Hartman wrote:
>> On Fri, Mar 27, 2020 at 08:34:52AM +0800, Rong Chen wrote:
>>>
>>> On 3/26/20 9:04 PM, Greg Kroah-Hartman wrote:
>>>> On Thu, Mar 26, 2020 at 08:28:58PM +0800, kbuild test robot wrote:
>>>>> Fixes: 87db1192dc33 ("usb: cdns3: make signed 1 bit bitfields 
>>>>> unsigned")
>>>> This original patch did not "cause" this problem, it's just that 
>>>> you for
>>>> some reason ran sparse for the first time on the file.
>>>>
>>>> So I can't take this as-is, can you remove this line and resend?
>>> Hi Greg,
>>>
>>> Sorry for the inconvenience, the patch was generated by the bot,
>>> we'll check and resend it.
>> It's fine that it was generated, it's a bug somewhere that thinks this
>> specific patch was a problem so that this generated patch fixed it.
> Yes, you are right, we'll fix the bug asap.
>

Hi Greg,

The commit 87db1192dc33 ("usb: cdns3: make signed 1 bit bitfields 
unsigned") fixed a sparse error
which causes many sparse warnings exposed, we'll remove the wrong 
"Fixes" in our patch in future.

Best Regards,
Rong Chen