[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <894dbbd4-be96-13ce-96b9-432b5d71f06b@gmail.com>
Date: Fri, 3 Apr 2020 23:58:40 +0300
From: Dmitry Osipenko <digetx@...il.com>
To: Thierry Reding <thierry.reding@...il.com>,
Daniel Lezcano <daniel.lezcano@...aro.org>,
Thomas Gleixner <tglx@...utronix.de>
Cc: Rob Herring <robh+dt@...nel.org>,
Jon Hunter <jonathanh@...dia.com>, devicetree@...r.kernel.org,
linux-tegra@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 2/7] clocksource: Add Tegra186 timers support
03.04.2020 23:22, Thierry Reding пишет:
...
> +static int tegra186_wdt_set_timeout(struct watchdog_device *wdd,
> + unsigned int timeout)
> +{
> + struct tegra186_wdt *wdt = to_tegra186_wdt(wdd);
> +
> + if (watchdog_active(&wdt->base))
> + tegra186_wdt_disable(wdt);
Could this and other tegra186_wdt_enable/disable occurrences race with
the interrupt handler?
Shouldn't IRQ be disabled/enable in a such cases to avoid the races?
> + wdt->base.timeout = timeout;
> +
> + if (watchdog_active(&wdt->base))
> + tegra186_wdt_enable(wdt);
> +
> + return 0;
> +}
Powered by blists - more mailing lists