linux-kernel - Re: [PATCH v3 2/7] clocksource: Add Tegra186 timers support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 4 Apr 2020 00:06:58 +0300
From:   Dmitry Osipenko <digetx@...il.com>
To:     Thierry Reding <thierry.reding@...il.com>,
        Daniel Lezcano <daniel.lezcano@...aro.org>,
        Thomas Gleixner <tglx@...utronix.de>
Cc:     Rob Herring <robh+dt@...nel.org>,
        Jon Hunter <jonathanh@...dia.com>, devicetree@...r.kernel.org,
        linux-tegra@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 2/7] clocksource: Add Tegra186 timers support

03.04.2020 23:51, Dmitry Osipenko пишет:
> 03.04.2020 23:22, Thierry Reding пишет:
> ...
>> +static irqreturn_t tegra186_timer_irq(int irq, void *data)
>> +{
>> +	struct tegra186_timer *tegra = data;
>> +
>> +	if (watchdog_active(&tegra->wdt->base)) {
>> +		tegra186_wdt_disable(tegra->wdt);
>> +		tegra186_wdt_enable(tegra->wdt);
>> +	}
> 
> Shouldn't this return IRQ_NONE if watchdog is inactive?
> 
>> +	return IRQ_HANDLED;
>> +}
> 

Could you please explain why this interrupt handler is needed at all?
Shouldn't the watchdog's core take care of the pinging?