linux-kernel - Re: [PATCH -next] clk: zynqmp: Make zynqmp_clk_get_max

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <713789e9-c947-44d4-cd66-06373537da31@xilinx.com>
Date:   Fri, 3 Apr 2020 10:37:57 +0200
From:   Michal Simek <michal.simek@...inx.com>
To:     YueHaibing <yuehaibing@...wei.com>, mturquette@...libre.com,
        sboyd@...nel.org, michal.simek@...inx.com, rajan.vaja@...inx.com,
        tejas.patel@...inx.com, m.tretter@...gutronix.de
Cc:     linux-clk@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next] clk: zynqmp: Make zynqmp_clk_get_max_divisor static

On 03. 04. 20 10:30, YueHaibing wrote:
> Fix sparse warning:
> 
> drivers/clk/zynqmp/divider.c:259:5: warning:
>  symbol 'zynqmp_clk_get_max_divisor' was not declared. Should it be static?
> 
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>
> ---
>  drivers/clk/zynqmp/divider.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/clk/zynqmp/divider.c b/drivers/clk/zynqmp/divider.c
> index 4be2cc76aa2e..1e93a4d32fa9 100644
> --- a/drivers/clk/zynqmp/divider.c
> +++ b/drivers/clk/zynqmp/divider.c
> @@ -256,7 +256,7 @@ static const struct clk_ops zynqmp_clk_divider_ops = {
>   * Return: Maximum divisor of a clock if query data is successful
>   *	   U16_MAX in case of query data is not success
>   */
> -u32 zynqmp_clk_get_max_divisor(u32 clk_id, u32 type)
> +static u32 zynqmp_clk_get_max_divisor(u32 clk_id, u32 type)
>  {
>  	const struct zynqmp_eemi_ops *eemi_ops = zynqmp_pm_get_eemi_ops();
>  	struct zynqmp_pm_query_data qdata = {0};
> 

Reviewed-by: Michal Simek <michal.simek@...inx.com>

Thanks,
Michal