linux-kernel - idx = rt5682_div_sel(rt5682, dmic_clk_rate, div, ARRAY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <202004061600.kSWORDaa%lkp@intel.com>
Date:   Mon, 6 Apr 2020 16:53:03 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Oder Chiou <oder_chiou@...ltek.com>
Cc:     kbuild-all@...ts.01.org, linux-kernel@...r.kernel.org,
        Mark Brown <broonie@...nel.org>
Subject: idx = rt5682_div_sel(rt5682, dmic_clk_rate, div, ARRAY_SIZE(div));

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   a10c9c710f9ecea87b9f4bbb837467893b4bef01
commit: 9a74c44a6f675e4e991437eee39496109b601629 ASoC: rt5682: Add a property for DMIC clock rate
date:   2 weeks ago

If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp@...el.com>


cppcheck warnings: (new ones prefixed by >>)

   sound/soc/codecs/rt5682.c:2394:65: warning: Boolean result is used in bitwise operation. Clarify expression with parentheses. [clarifyCondition]
         (pll_code.m_bp ? 0 : pll_code.m_code) << RT5682_PLL_M_SFT |
                                                                   ^
   sound/soc/codecs/rt5682.c:1240:6: warning: Redundant initialization for 'idx'. The initialized value is overwritten before it is read. [redundantInitialization]
>>  idx = rt5682_div_sel(rt5682, dmic_clk_rate, div, ARRAY_SIZE(div));
        ^
   sound/soc/codecs/rt5682.c:1234:10: note: idx is initialized
>>  int idx = -EINVAL, dmic_clk_rate = 3072000;
            ^
   sound/soc/codecs/rt5682.c:1240:6: note: idx is overwritten
>>  idx = rt5682_div_sel(rt5682, dmic_clk_rate, div, ARRAY_SIZE(div));
        ^
   sound/soc/codecs/rt5682.c:1269:6: warning: Redundant initialization for 'idx'. The initialized value is overwritten before it is read. [redundantInitialization]
    idx = rt5682_div_sel(rt5682, ref, div_f, ARRAY_SIZE(div_f));
        ^
   sound/soc/codecs/rt5682.c:1254:25: note: idx is initialized
    int ref, val, reg, idx = -EINVAL;
                           ^
   sound/soc/codecs/rt5682.c:1269:6: note: idx is overwritten
    idx = rt5682_div_sel(rt5682, ref, div_f, ARRAY_SIZE(div_f));
        ^
   sound/soc/codecs/rt5682.c:918:15: warning: The scope of the variable 'val' can be reduced. [variableScope]
    unsigned int val, count;
                 ^
   sound/soc/codecs/rt5682.c:918:20: warning: The scope of the variable 'count' can be reduced. [variableScope]
    unsigned int val, count;
                      ^
   sound/soc/codecs/rt5682.c:1085:11: warning: The scope of the variable 'btn_type' can be reduced. [variableScope]
    int val, btn_type;
             ^
   sound/soc/codecs/rt5682.c:2288:15: warning: The scope of the variable 'pll2_fout1' can be reduced. [variableScope]
    unsigned int pll2_fout1;
                 ^
   sound/soc/codecs/rt5682.c:2844:16: warning: The scope of the variable 'time' can be reduced. [variableScope]
    unsigned long time;
                  ^
   sound/soc/codecs/rt5682.c:2733:7: warning: Either the condition '!dai' is redundant or there is possible null pointer dereference: dai. [nullPointerRedundantCheck]
     if (dai->id == RT5682_AIF1)
         ^
   sound/soc/codecs/rt5682.c:2735:6: note: Assuming that condition '!dai' is not redundant
    if (!dai) {
        ^
   sound/soc/codecs/rt5682.c:2733:7: note: Null pointer dereference
     if (dai->id == RT5682_AIF1)
         ^

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org