linux-kernel - Re: [PATCH] power: supply: axp288_fuel_gauge: Add the Meegopad T02 to the blacklist.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <eff57daf-6f71-1f6f-e4f9-5b5b1ed974cd@redhat.com>
Date:   Mon, 6 Apr 2020 17:44:04 +0200
From:   Hans de Goede <hdegoede@...hat.com>
To:     rafirafi <rafirafi.at@...il.com>
Cc:     Sebastian Reichel <sre@...nel.org>, Chen-Yu Tsai <wens@...e.org>,
        linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] power: supply: axp288_fuel_gauge: Add the Meegopad T02 to
 the blacklist.

Hi,

On 4/6/20 4:05 PM, rafirafi wrote:
> From: Rafael Gandolfi <rafirafi.at@...il.com>
> 
>      The Meegopad T02 is a PC in stick format and doesn't have a battery,
>      it is reported with a random and constant battery charge but as
>      discharging to userspace.
> 
>      Add it to the blacklist to avoid the bogus battery status reporting.
> 
> Signed-off-by: Rafael Gandolfi <rafirafi.at@...il.com>

Patch looks good to me:

Reviewed-by: Hans de Goede <hdegoede@...hat.com>

Regards,

Hans


> ---
>   drivers/power/supply/axp288_fuel_gauge.c | 6 ++++++
>   1 file changed, 6 insertions(+)
> 
> diff --git a/drivers/power/supply/axp288_fuel_gauge.c b/drivers/power/supply/axp288_fuel_gauge.c
> index e1bc4e6e6f30..0bc548865a61 100644
> --- a/drivers/power/supply/axp288_fuel_gauge.c
> +++ b/drivers/power/supply/axp288_fuel_gauge.c
> @@ -717,6 +717,12 @@ static const struct dmi_system_id axp288_fuel_gauge_blacklist[] = {
>   			DMI_MATCH(DMI_PRODUCT_NAME, "STK1A32SC"),
>   		},
>   	},
> +	{
> +		/* Meegopad T02 */
> +		.matches = {
> +			DMI_MATCH(DMI_PRODUCT_NAME, "MEEGOPAD T02"),
> +		},
> +	},
>   	{
>   		/* Meegopad T08 */
>   		.matches = {
>