linux-kernel - Re: [git pull] regression fix in namei

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHk-=wj2UALsz8=R54WLGzhz8mGqzMnKqV1E=SaFOETYhrjYYg@mail.gmail.com>
Date:   Mon, 6 Apr 2020 08:45:41 -0700
From:   Linus Torvalds <torvalds@...ux-foundation.org>
To:     Al Viro <viro@...iv.linux.org.uk>
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        linux-fsdevel <linux-fsdevel@...r.kernel.org>
Subject: Re: [git pull] regression fix in namei

On Mon, Apr 6, 2020 at 7:40 AM Al Viro <viro@...iv.linux.org.uk> wrote:
>
>         Dumb braino in legitimize_path()...

Well, the type system can't help us because the types are the same,
but I do wonder if at least the naming couldn't have been slightly
more explicit. "mseq" vs "seq" is a bit subtle.

I guess this is mostly a one-time conversion issue, so not worth
trying to worry about any more, but that internal interface does look
like it's ripe for mistakes.

              Linus