linux-kernel - Re: [PATCH v5 2/7] tpm: tpm_tis: Add check_data handle to tpm_tis_phy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 6 Apr 2020 21:28:59 +0300
From:   Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>
To:     amirmizi6@...il.com
Cc:     Eyal.Cohen@...oton.com, oshrialkoby85@...il.com,
        alexander.steffen@...ineon.com, robh+dt@...nel.org,
        peterhuewe@....de, christophe-h.richard@...com, jgg@...pe.ca,
        arnd@...db.de, gregkh@...uxfoundation.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-integrity@...r.kernel.org, oshri.alkoby@...oton.com,
        tmaimon77@...il.com, gcwilson@...ibm.com, kgoldman@...ibm.com,
        Dan.Morav@...oton.com, oren.tanami@...oton.com,
        shmulik.hager@...oton.com, amir.mizinski@...oton.com,
        Christophe Ricard <christophe-h.ricard@...com>
Subject: Re: [PATCH v5 2/7] tpm: tpm_tis: Add check_data handle to
 tpm_tis_phy_ops in order to check data integrity

Short summary could just be:

"Add check_data handle() to struct tpm_tis_phy_ops"

and leave the reasoning to the long description.

On Sun, Apr 05, 2020 at 03:53:47PM +0300, amirmizi6@...il.com wrote:
> From: Amir Mizinski <amirmizi6@...il.com>
> 
> In order to compute the crc over the data sent in lower layer
> (I2C for instance), tpm_tis_check_data() calls an operation (if available)
> to check data integrity. If data integrity cannot be verified, a retry
> attempt to save the sent/received data is implemented.

It does not. The existing code does not do that.

Also it is not clear whether the steps are from existing code or
after this commit has been applied.

/Jarkko