linux-kernel - Re: [PATCH 8/8] mmap locking API: rename mmap_sem to mmap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200406160356.py26by67dhprte5d@linux-p48b>
Date:   Mon, 6 Apr 2020 09:03:56 -0700
From:   Davidlohr Bueso <dave@...olabs.net>
To:     Laurent Dufour <ldufour@...ux.ibm.com>
Cc:     Michel Lespinasse <walken@...gle.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        linux-mm <linux-mm@...ck.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Peter Zijlstra <peterz@...radead.org>,
        Vlastimil Babka <vbabka@...e.cz>,
        Matthew Wilcox <willy@...radead.org>,
        Liam Howlett <Liam.Howlett@...cle.com>,
        Jerome Glisse <jglisse@...hat.com>,
        David Rientjes <rientjes@...gle.com>,
        Hugh Dickins <hughd@...gle.com>, Ying Han <yinghan@...gle.com>
Subject: Re: [PATCH 8/8] mmap locking API: rename mmap_sem to mmap_lock

On Mon, 06 Apr 2020, Laurent Dufour wrote:

>Le 26/03/2020 à 08:02, Michel Lespinasse a écrit :
>>Rename the mmap_sem field to mmap_lock. Any new uses of this lock
>>should now go through the new mmap locking api. The mmap_lock is
>>still implemented as a rwsem, though this could change in the future.
>
>Since you don't change the type of the mmap_sem, it's still a 
>semaphore, I don't think mmap_lock is a good name. This is not a lock.

Well a semaphore is still a kind of lock. I think the naming in this
patch is good and generic enough.

Thanks,
Davidlohr