linux-kernel - Re: [PATCH] iio: adc: ad7192: fix null de-ref crash during probe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <4ff0776f-b5de-536a-ccf9-7516f1a65d87@web.de>
Date:   Mon, 6 Apr 2020 21:46:59 +0200
From:   Markus Elfring <Markus.Elfring@....de>
To:     Alexandru Ardelean <alexandru.ardelean@...log.com>,
        linux-iio@...r.kernel.org
Cc:     Alexandru Tachici <alexandru.tachici@...log.com>,
        Jonathan Cameron <jic23@...nel.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] iio: adc: ad7192: fix null de-ref crash during probe

> After that patch 'spi_get_device_id(spi)' returns NULL, so this crashes
> during probe with null de-ref.

How do you think about to use the term “null pointer dereference”
in the commit message?

> Fixes 66614ab2be38: ("staging: iio: adc: ad7192: removed spi_device_id")

Please correct this tag.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=7e63420847ae5f1036e4f7c42f0b3282e73efbc2#n183

Why was a colon misplaced here?

Regards,
Markus