linux-kernel - Re: [PATCH] iio: adc: ad7192: fix null de-ref crash during probe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 7 Apr 2020 04:59:01 +0000
From:   "Ardelean, Alexandru" <alexandru.Ardelean@...log.com>
To:     "Markus.Elfring@....de" <Markus.Elfring@....de>,
        "linux-iio@...r.kernel.org" <linux-iio@...r.kernel.org>
CC:     "jic23@...nel.org" <jic23@...nel.org>,
        "Tachici, Alexandru" <Alexandru.Tachici@...log.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] iio: adc: ad7192: fix null de-ref crash during probe

On Mon, 2020-04-06 at 21:46 +0200, Markus Elfring wrote:
> > After that patch 'spi_get_device_id(spi)' returns NULL, so this crashes
> > during probe with null de-ref.
> 
> How do you think about to use the term “null pointer dereference”
> in the commit message?

depends how long the commit title with be
will take a look

> 
> 
> > Fixes 66614ab2be38: ("staging: iio: adc: ad7192: removed spi_device_id")
> 
> Please correct this tag.
> https://urldefense.com/v3/__https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=7e63420847ae5f1036e4f7c42f0b3282e73efbc2*n183__;Iw!!A3Ni8CS0y2Y!uk9bOaD_449N0PxwtQ_WikWYY5KnpykeZTp-rbrRTju7FZM6fPd48zCD1pe7rTSYypKYkg$ 
> 
> Why was a colon misplaced here?

will fix
thanks

> 
> Regards,
> Markus