linux-kernel - Re: [PATCH 5/5] usb: chipidea: allow disabling glue drivers if EMBEDDED

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200407200037.GB744@qmqm.qmqm.pl>
Date:   Tue, 7 Apr 2020 22:00:37 +0200
From:   Michał Mirosław <mirq-linux@...e.qmqm.pl>
To:     Peter Chen <peter.chen@....com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>
Subject: Re: [PATCH 5/5] usb: chipidea: allow disabling glue drivers if
 EMBEDDED

On Tue, Apr 07, 2020 at 03:12:36AM +0000, Peter Chen wrote:
> On 20-04-04 02:00:06, Michał Mirosław wrote:
> > Allow to cut down on driver size for embedded config.
> > 
> > Signed-off-by: Michał Mirosław <mirq-linux@...e.qmqm.pl>
> > ---
> >  drivers/usb/chipidea/Kconfig  | 37 ++++++++++++++++++++++++-----------
> >  drivers/usb/chipidea/Makefile | 12 +++++-------
> >  2 files changed, 31 insertions(+), 18 deletions(-)
> > 
> > diff --git a/drivers/usb/chipidea/Kconfig b/drivers/usb/chipidea/Kconfig
> > index d53db520e209..8bafcfc6080d 100644
> > --- a/drivers/usb/chipidea/Kconfig
> > +++ b/drivers/usb/chipidea/Kconfig
> > @@ -18,17 +18,6 @@ config USB_CHIPIDEA
> >  
> >  if USB_CHIPIDEA
> >  
> > -config USB_CHIPIDEA_OF
> > -	tristate
> > -	depends on OF
> > -	default USB_CHIPIDEA
> > -
> > -config USB_CHIPIDEA_PCI
> > -	tristate
> > -	depends on USB_PCI
> > -	depends on NOP_USB_XCEIV
> > -	default USB_CHIPIDEA
> > -
> >  config USB_CHIPIDEA_UDC
> >  	bool "ChipIdea device controller"
> >  	depends on USB_GADGET
> > @@ -43,4 +32,30 @@ config USB_CHIPIDEA_HOST
> >  	help
> >  	  Say Y here to enable host controller functionality of the
> >  	  ChipIdea driver.
> > +
> > +config USB_CHIPIDEA_PCI
> > +	tristate "Enable PCI glue driver" if EMBEDDED
[...]
> Why depends on EMBEDDED for this driver? Not everyone needs this
> configuration.

This does not make the driver depend on EMBEDDED, only the prompts are.
By default (without CONFIG_EMBEDDED) you will have all glue layers built
if you enable the driver. I can remove the 'if EMBEDDED', but
I suppose those options are only relevant for people building for
resource-constrained systems, so would have EMBEDDED enabled anyway.

Best Regards,
Michał Mirosław