linux-kernel - Re: [PATCH v1 28/28] i2c: octeon-platdrv: convert to devm_platform_ioremap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 7 Apr 2020 22:00:28 +0200
From:   Robert Richter <rrichter@...vell.com>
To:     Dejin Zheng <zhengdejin5@...il.com>
CC:     <thor.thayer@...ux.intel.com>, <krzysztof.adamski@...ia.com>,
        <rjui@...adcom.com>, <sbranden@...adcom.com>,
        <bcm-kernel-feedback-list@...adcom.com>, <f.fainelli@...il.com>,
        <nsekhar@...com>, <bgolaszewski@...libre.com>,
        <jarkko.nikula@...ux.intel.com>,
        <andriy.shevchenko@...ux.intel.com>,
        <mika.westerberg@...ux.intel.com>, <baruch@...s.co.il>,
        <wsa+renesas@...g-engineering.com>, <kgene@...nel.org>,
        <krzk@...nel.org>, <paul@...pouillou.net>, <vz@...ia.com>,
        <khilman@...libre.com>, <matthias.bgg@...il.com>,
        <gregory.clement@...tlin.com>, <afaerber@...e.de>,
        <manivannan.sadhasivam@...aro.org>, <agross@...nel.org>,
        <bjorn.andersson@...aro.org>, <heiko@...ech.de>,
        <baohua@...nel.org>, <linus.walleij@...aro.org>,
        <mripard@...nel.org>, <wens@...e.org>, <ardb@...nel.org>,
        <michal.simek@...inx.com>, <gcherian@...vell.com>,
        <jun.nie@...aro.org>, <shawnguo@...nel.org>,
        <rayagonda.kokatanur@...adcom.com>, <lori.hikichi@...adcom.com>,
        <nishkadg.linux@...il.com>, <kstewart@...uxfoundation.org>,
        <allison@...utok.net>, <gregkh@...uxfoundation.org>,
        <tglx@...utronix.de>, <bigeasy@...utronix.de>, <info@...ux.net>,
        <hslester96@...il.com>, <narmstrong@...libre.com>,
        <martin.blumenstingl@...glemail.com>, <qii.wang@...iatek.com>,
        <drinkcat@...omium.org>, <hsinyi@...omium.org>,
        <fparent@...libre.com>, <opensource@...ayne.com>,
        <swinslow@...il.com>, <linux-i2c@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH v1 28/28] i2c: octeon-platdrv: convert to
 devm_platform_ioremap_resource

On 08.04.20 00:37:41, Dejin Zheng wrote:
> use devm_platform_ioremap_resource() to simplify code, which
> contains platform_get_resource and devm_ioremap_resource.
> 
> Signed-off-by: Dejin Zheng <zhengdejin5@...il.com>

Acked-by: Robert Richter <rrichter@...vell.com>

> ---
>  drivers/i2c/busses/i2c-octeon-platdrv.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/i2c/busses/i2c-octeon-platdrv.c b/drivers/i2c/busses/i2c-octeon-platdrv.c
> index 64bda83e65ac..0c227963c8d6 100644
> --- a/drivers/i2c/busses/i2c-octeon-platdrv.c
> +++ b/drivers/i2c/busses/i2c-octeon-platdrv.c
> @@ -136,7 +136,6 @@ static int octeon_i2c_probe(struct platform_device *pdev)
>  {
>  	struct device_node *node = pdev->dev.of_node;
>  	int irq, result = 0, hlc_irq = 0;
> -	struct resource *res_mem;
>  	struct octeon_i2c *i2c;
>  	bool cn78xx_style;
>  
> @@ -167,8 +166,7 @@ static int octeon_i2c_probe(struct platform_device *pdev)
>  	i2c->roff.twsi_int = 0x10;
>  	i2c->roff.sw_twsi_ext = 0x18;
>  
> -	res_mem = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -	i2c->twsi_base = devm_ioremap_resource(&pdev->dev, res_mem);
> +	i2c->twsi_base = devm_platform_ioremap_resource(pdev, 0);
>  	if (IS_ERR(i2c->twsi_base)) {
>  		result = PTR_ERR(i2c->twsi_base);
>  		goto out;
> -- 
> 2.25.0
>